refactor(toolchain/names): replace toolchain_sort() with ToolchainName's Ord instance#3892
Merged
rami3l merged 3 commits intorust-lang:masterfrom Jun 19, 2024
Merged
Conversation
rami3l
force-pushed
the
refactor/toolchain-name-sort
branch
from
f738c39 to
e147d73
Compare
djc
reviewed
Jun 18, 2024
rami3l
force-pushed
the
refactor/toolchain-name-sort
branch
4 times, most recently
from
171e53a to
3cb64d8
Compare
rami3l
changed the title
ToolchainName's Ord instancetoolchain_sort() with ToolchainName's Ord instance
rami3l
force-pushed
the
refactor/toolchain-name-sort
branch
from
3cb64d8 to
6cdf0b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3884.
This new implementation also tries to correct the handling of
X.Y,X.Y-beta.WandX.Y.Z-beta.Wversions' ordering by abusingsemver::Comparator'sFromStrimplementation.