Skip to content

Conversation

@rami3l
Copy link
Member

@rami3l rami3l commented Jan 21, 2025

Implements #4157 (comment).

This basically mirrors astral-sh/uv#7888, however I have no idea if that magic comment will work at all...

If it works, then locking taplo might be a good idea as well.

@rami3l rami3l added this to the 1.28.0 milestone Jan 21, 2025
@rami3l rami3l requested review from ChrisDenton and djc January 21, 2025 16:06
Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

This basically mirrors astral-sh/uv#7888, however I have no idea if that magic comment will work at all...

Only one way to find out?

Copy link
Member

@ChrisDenton ChrisDenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The test failures look unrelated?

@rami3l rami3l enabled auto-merge January 21, 2025 23:52
@rami3l rami3l added this pull request to the merge queue Jan 22, 2025
Merged via the queue into rust-lang:master with commit 817eae0 Jan 22, 2025
29 checks passed
@rami3l rami3l deleted the ci/mdbook-pin-update branch January 22, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants