Enhance mentions with glob patterns matching#2244
Merged
Urgau merged 4 commits intorust-lang:masterfrom Jan 5, 2026
Merged
Conversation
Member
I assume this was supposed to say "In order to not break the world" :D |
Kobzol
approved these changes
Jan 5, 2026
Member
Author
🤦, yes, to not break the world. |
Kobzol
added a commit
to Kobzol/rust
that referenced
this pull request
Jan 7, 2026
Factorize `triagebot.toml` float parsing mentions with a glob matching Related to rust-lang/triagebot#2244. r? @tgross35
rust-timer
added a commit
to rust-lang/rust
that referenced
this pull request
Jan 8, 2026
Rollup merge of #150738 - triagebot-first-glob-use, r=tgross35 Factorize `triagebot.toml` float parsing mentions with a glob matching Related to rust-lang/triagebot#2244. r? @tgross35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds supports for glob patterns matching in the
[mentions]file path matching.We currently use a "starts with" matching, but users have expressed the desire for more expressiveness #1855.
In order to not break the world, we add an implicit
*at the end to make the glob always a "starts with" pattern.I have also switch library from
globtoglobsetas alternates ({foo,bar}) are not supported by the former.Fixes #1855
cc @tgross35