add rank-1 update of Cholesky decomposition#14
Open
AndersonYin wants to merge 2 commits intorust-ml:mainfrom
Open
add rank-1 update of Cholesky decomposition#14AndersonYin wants to merge 2 commits intorust-ml:mainfrom
AndersonYin wants to merge 2 commits intorust-ml:mainfrom
Conversation
YuhanLiin
reviewed
Apr 13, 2024
Comment on lines
+4
to
+6
| pub trait CholeskyUpdate<F> { | ||
| fn cholesky_update_inplace(&mut self, update_vector: &Array1<F>); | ||
| } |
Collaborator
There was a problem hiding this comment.
Can you add documentation to this trait?
YuhanLiin
reviewed
Apr 13, 2024
| let mut w=update_vector.to_owned(); | ||
| let mut b=F::from(1.0).unwrap(); | ||
| for j in 0..n{ | ||
| let ljj=self[(j,j)]; |
Collaborator
There was a problem hiding this comment.
For indexing, use the traits in index.rs, which are faster in release mode.
Collaborator
|
Can you merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've implemented the rank-one update of Cholesky decomposition following the paper (Krause & Igel, 2015).
references: Krause, O., & Igel, C. (2015, January). A more efficient rank-one covariance matrix update for evolution strategies. In Proceedings of the 2015 ACM Conference on Foundations of Genetic Algorithms XIII (pp. 129-136).