Skip to content

Fix label ordering in binary logistic regression#432

Merged
relf merged 1 commit intorust-ml:masterfrom
espenloov:logistic-label-ordering
Mar 18, 2026
Merged

Fix label ordering in binary logistic regression#432
relf merged 1 commit intorust-ml:masterfrom
espenloov:logistic-label-ordering

Conversation

@espenloov
Copy link
Copy Markdown
Contributor

@espenloov espenloov commented Mar 17, 2026

Fixes #393. It now assigns positive/negative labels based on Ord ordering of the label values rather than encounter order in the training data.

…ow assings positive/negative labels based on Ord ordering of the label values rather than encouter order in the training dat
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.73%. Comparing base (c7c2af5) to head (6dcc5cf).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #432      +/-   ##
==========================================
- Coverage   76.76%   76.73%   -0.04%     
==========================================
  Files         106      106              
  Lines        7411     7410       -1     
==========================================
- Hits         5689     5686       -3     
- Misses       1722     1724       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@relf relf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@relf relf changed the title Fixes #393. label ordering in binary logistic regression, it now assi… Fix label ordering in binary logistic regression Mar 18, 2026
@relf relf merged commit 17f8696 into rust-ml:master Mar 18, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linfa-logistic: labels are not Ord ordered, 'neg' is the one first found in data during training

2 participants