ndk-example: Demonstrate Looper usage without winit#161
Merged
Conversation
MarijnS95
commented
Jul 26, 2021
Comment on lines
+134
to
+157
| // Stop the activity | ||
| ndk_glue::native_activity().finish() |
Member
Author
There was a problem hiding this comment.
This is still pending #160; but we can get this PR in already and it will just have to be cleaned up there (and it should probably fail to compile no matter how we implement it).
msiglreith
approved these changes
Aug 7, 2021
Contributor
msiglreith
left a comment
msiglreith
left a comment
There was a problem hiding this comment.
that's a nice reference!
Originally proposed [here], this adds a simple looper example demonstrating how to use Android's `Looper` through the NDK bindings in similar fashion to `winit`. It uses `ndk_glue`'s event pipe, Android's `InputQueue` and a custom Unix pipe to transfer events to the Looper (thread). [here]: rust-mobile#111 (comment)
MarijnS95
force-pushed
the
looper-example
branch
from
1265d0b to
f3db9f6
Compare
Member
Author
|
@msiglreith Thanks for reviewing! Wanted to hold off merging until finalizing all the changes to |
msiglreith
approved these changes
Aug 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #111
Originally proposed here, this adds a simple looper example demonstrating how to use Android's
Looperthrough the NDK bindings in similar fashion towinit. It usesndk_glue's event pipe, Android'sInputQueueand a custom Unix pipe to transfer events to the Looper (thread).