ndk/input: Allow any non-zero return in pre_dispatch() again#325
Merged
Merged
Conversation
MarijnS95
force-pushed
the
ndk-0.7.1-fix-pre_dispatch-returncode-handling
branch
from
3c831e4 to
f39287c
Compare
Despite the [Android source] never returning anything other than `0` or `1` there appear to be platforms out in the wild that take [the documentation] quite literally and return vague non-zero codes apart `1` with a possible secondary meaning. [Android source]: https://cs.android.com/android/platform/superproject/+/master:frameworks/base/core/jni/android_view_InputQueue.cpp;drc=b6d7f3b484e4c32c144c66bee342c29e7a8d34cc;l=115 [the documentation]: https://developer.android.com/ndk/reference/group/input#ainputqueue_predispatchevent
MarijnS95
force-pushed
the
ndk-0.7.1-fix-pre_dispatch-returncode-handling
branch
from
f39287c to
1dd61e2
Compare
MarijnS95
changed the title
pre_dispatch() again, release ndk-0.7.1pre_dispatch() again
msiglreith
approved these changes
Nov 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #322
Despite the Android source never returning anything other than
0or1there appear to be platforms out in the wild that take the documentation quite literally and return vague non-zero codes apart1with a possible secondary meaning.