Made hole module public for external uses.

[MarcoCicognani]

Hi Phil!

I've made hole.rs public for external uses and moved align_layout() function into HoleList.

Heap still contains the size and the used counters, so it is still Heap that uses align_layout.
Tell me if this is not the best solution

[phil-opp]

Thanks!

Heap still contains the size and the used counters, so it is still Heap that uses align_layout.
Tell me if this is not the best solution

I would prefer to move the align_layout calls to HoleList::allocate_first_fit and HoleList::deallocate. Maybe we could use a &mut Layout reference as argument, which is then adjusted. Alternatively, we could also return the adjusted Layout as a second return type. What do you think?

[MarcoCicognani]

I think that is a good idea.
I implement it immediately

[MarcoCicognani]

But size and used must remain into Heap, right?

[phil-opp]

Yes, I would keep them in Heap, to keep the HoleList as simple as possible.

[MarcoCicognani]

Well, done!

[phil-opp]

Thanks! A few more nits, then this should be ready.

[phil-opp]

Could you update the docs for the new second return type? For example:

"[...] Then the start address of that block and the aligned layout are returned. The automatic layout alignment is required because the HoleList has some additional layout requirements for each memory block."

[phil-opp]

You could simplify this with a match to avoid the unwrap():

match self.holes.allocate_first_fit(layout) {
    Ok((ptr, aligned_layout)) => {
        self.used += aligned_layout.size();
        Ok(ptr)
    }
    Err(err) => Err(err),
}

[MarcoCicognani]

Done

[phil-opp]

Thank you!

[phil-opp]

Published as v0.8.10