Add new use_spin_nightly feature #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thalesfragoso
force-pushed
the
spin-night
branch
from
44959cb to
fe9f01c
Compare
phil-opp
reviewed
Jan 2, 2021
Member
phil-opp
left a comment
phil-opp
left a comment
There was a problem hiding this comment.
Thanks a lot for reporting this issue and directly providing a fix!
The changes look good to me overall, I just think that we should enable the new use_spin_feature by default (see inline comment).
thalesfragoso
force-pushed
the
spin-night
branch
from
fe9f01c to
15e7940
Compare
Member
|
Thank! |
Member
|
Published as v0.8.11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #48, at least until we get rust-lang/cargo#8832
Closes #48