Remove unnecessary error branch of ProcessPrng#579
Merged
newpavlov merged 2 commits intorust-random:masterfrom Jan 12, 2025
silverstillisntgold:master
Merged
Remove unnecessary error branch of ProcessPrng#579newpavlov merged 2 commits intorust-random:masterfrom silverstillisntgold:master
newpavlov merged 2 commits intorust-random:masterfrom
silverstillisntgold:master
Conversation
associated cleanup and documentation
newpavlov
reviewed
Jan 9, 2025
josephlr
previously requested changes
Jan 10, 2025
newpavlov
approved these changes
Jan 12, 2025
takumi-earth
pushed a commit
to earthlings-dev/getrandom
that referenced
this pull request
Jan 27, 2026
ProcessPrng is guaranteed to never fail during runtime, so there's no need to handle that case. Also found that windows_targets declares all extern functions as pub, so wrapped the link! macro in a local module to prevent it from being accessible outside of windows.rs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProcessPrng is guaranteed to never fail during runtime, so there's no need to handle that case. Also found that windows_targets declares all extern functions as pub, so wrapped the link! macro in a local module to prevent it from being accessible outside of windows.rs.
When getrandom increases the MSRV to at least 1.71, the windows-targets crate can be ditched entirely in favor of linking with raw-dylib.