unsupported opt-in backend#667
Merged
newpavlov merged 5 commits intorust-random:masterfrom May 19, 2025
Merged
Conversation
dsherret
force-pushed
the
runtime_error_backend
branch
from
c0538d9 to
903c641
Compare
dsherret
force-pushed
the
runtime_error_backend
branch
from
903c641 to
b7384b7
Compare
Closed
newpavlov
reviewed
May 19, 2025
Member
newpavlov
left a comment
newpavlov
left a comment
There was a problem hiding this comment.
Looks mostly good, but I am not sure about the backend name. How about unsupported since it returns Error::UNSUPPORTED?
Contributor
Author
I wasn't sure about it either. Yeah, I like that better. Updated. |
Member
|
Also, please add a changelog entry. You can add the following section: The diff link goes to the end of the file. |
newpavlov
reviewed
May 19, 2025
josephlr
approved these changes
May 19, 2025
Member
josephlr
left a comment
josephlr
left a comment
There was a problem hiding this comment.
Looks reasonable to me. Thanks for adding this!
I'm going to try to see if the CI errors are just spurious failures or something we need to fix. Regardless, the failures aren't being caused by this PR.
Member
|
Thank you! We probably will wait for some time before releasing v0.3.4 to accumulate other potential changes. Meanwhile, you could temporarily patch |
Merged
josephlr
added a commit
that referenced
this pull request
Oct 14, 2025
## [0.3.4] - 2025-10-14 ### Major change to `wasm_js` backend Now, when the `wasm_js` feature is enabled, the `wasm_js` backend will be used by default. Users of `wasm32-unknown-unknown` targeting JavaScript environments like the Web and Node.js will no longer need to specify: ``` --cfg getrandom_backend="wasm_js" ``` in `RUSTFLAGS` for the crate to compile. They can now simple enable a feature. Note: this should not affect non-JS users of the `wasm32-unknown-unknown` target. Using `--cfg getrandom_backend` will still override the source of randomness _even if_ the `wasm_js` feature is enabled. This includes `--cfg getrandom_backend=custom` and `--cfg getrandom_backend=unsupported`. For more information, see the discussions in [#671], [#675], and [#730]. ### Added - `unsupported` opt-in backend [#667] - `windows_legacy` opt-in backend [#724] ### Changed - Implement Memory Sanitizer unpoisoning more precisely [#678] - Relax MSRV for the `linux_raw` opt-in backend on ARM targets [#688] - Use `getrandom` syscall on all RISC-V Linux targets [#699] - Replaced `wasi` dependency with `wasip2` [#721] - Enable `wasm_js` backend by default if the `wasm_js` feature is enabled [#730] ### Removed - Unstable `rustc-dep-of-std` crate feature [#694] [#667]: #667 [#671]: #671 [#675]: #675 [#678]: #678 [#688]: #688 [#694]: #694 [#699]: #699 [#721]: #721 [#724]: #724 [#730]: #730 --------- Signed-off-by: Joe Richey <joerichey@google.com>
takumi-earth
pushed a commit
to earthlings-dev/getrandom
that referenced
this pull request
Jan 27, 2026
The backend always returns `Err(Error::UNSUPPORTED)`.
takumi-earth
pushed a commit
to earthlings-dev/getrandom
that referenced
this pull request
Jan 27, 2026
## [0.3.4] - 2025-10-14 ### Major change to `wasm_js` backend Now, when the `wasm_js` feature is enabled, the `wasm_js` backend will be used by default. Users of `wasm32-unknown-unknown` targeting JavaScript environments like the Web and Node.js will no longer need to specify: ``` --cfg getrandom_backend="wasm_js" ``` in `RUSTFLAGS` for the crate to compile. They can now simple enable a feature. Note: this should not affect non-JS users of the `wasm32-unknown-unknown` target. Using `--cfg getrandom_backend` will still override the source of randomness _even if_ the `wasm_js` feature is enabled. This includes `--cfg getrandom_backend=custom` and `--cfg getrandom_backend=unsupported`. For more information, see the discussions in [rust-random#671], [rust-random#675], and [rust-random#730]. ### Added - `unsupported` opt-in backend [rust-random#667] - `windows_legacy` opt-in backend [rust-random#724] ### Changed - Implement Memory Sanitizer unpoisoning more precisely [rust-random#678] - Relax MSRV for the `linux_raw` opt-in backend on ARM targets [rust-random#688] - Use `getrandom` syscall on all RISC-V Linux targets [rust-random#699] - Replaced `wasi` dependency with `wasip2` [rust-random#721] - Enable `wasm_js` backend by default if the `wasm_js` feature is enabled [rust-random#730] ### Removed - Unstable `rustc-dep-of-std` crate feature [rust-random#694] [rust-random#667]: rust-random#667 [rust-random#671]: rust-random#671 [rust-random#675]: rust-random#675 [rust-random#678]: rust-random#678 [rust-random#688]: rust-random#688 [rust-random#694]: rust-random#694 [rust-random#699]: rust-random#699 [rust-random#721]: rust-random#721 [rust-random#724]: rust-random#724 [rust-random#730]: rust-random#730 --------- Signed-off-by: Joe Richey <joerichey@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An alternative to #666 that errors at runtime.
This is useful when needing the crate to compile when targeting wasm32, but this code is never actually hit.