Conversation
|
#794 should be merged first. |
|
Note that in the custom backend we still use |
fc4a0e6 to
9cefeda
Compare
|
Published. @newpavlov will you make the GH release? |
|
Since we switched to Trusted Publishing you just need to push new version tag and with the current configuration the workflow needs your approval, so it's probably better for you to push the tag. UPD: Ah, I see. The environment settings have changed and the list of reviewers now includes me and Joe. Either way, you already pushed the tag. |
|
@dhardy |
|
I was referring to GitHub releases which aren't automated... or used at all in this case. Never mind. You can change the requirements to prevent self-review if you like, but yes it is essentially an honour system. The more interesting part would be if we can require a release version to be published to either master or a backports branch, but I'm not sure exactly how the checks work. We could try that. |
|
(I assumed that since this PR was approved that it was fine to also push the tag.) |
As I wrote in one of issues, personally I don't think we should bother with GH releases, regardless whether they are created manually or using a workflow. |
|
The only use I see for them is that people can choose to "watch releases" on GitHub which I do for a few things, though I don't find it massively useful. |
Release PR: rust-random/getrandom#798
Release PR: rust-random/getrandom#798
Release PR: rust-random/getrandom#798
|
It's nice to have a page with the release notes for just one particular release, but I can always link to the changelog |
Release PR: rust-random/getrandom#798
Release PR: rust-random/getrandom#798
I believe this is ready for release (see #722)?