Conversation
|
I wouldn't say that bumping MSRV to 1.51 is a "minor thing". |
|
The actual bump was already merged: #1246. |
There was a problem hiding this comment.
Personally, I think 1.51 could be a bit too steep for a crate like rand. With bump to 1.38 we could shift responsibility to crossbeam, it's much less impactful, and it's easier to pin one crate to preserve the old MSRV, than a number of affected rand crates. Be prepared to the same reaction as we've seen for once_cell, if not worse.
But I guess, it's too late to raise such concerns...
|
The next Rand release will be a breaking release. Given that, and that 1.51 is likely to be two years old by the time Rand 0.9 releases (or more, we're not exactly making rapid progress on it), I don't think this is an issue. |
|
Ah, if MSRV bump will be done as part of v0.9, then I have no objections. It could be even worth to bump to 1.56 for edition update. |
|
👍 The gh-pages deployment needs fixing :-( |
* examples/rayon-monte-carlo.rs: remove execute bit of file metadata * Document in README that MSRV is 1.51.0 This was changed in rust-random#1246 * Update GitHub Actions
2 participants
... plus a couple of minor things