Small changes from experimental branch#273
Merged
dhardy merged 5 commits intorust-random:masterfrom Feb 28, 2018
Merged
Conversation
Rationale: lib.rs should not contain a big mess of unrelated code
Changes come from dhardy/master branch
pitdicker
approved these changes
Feb 28, 2018
Contributor
pitdicker
left a comment
There was a problem hiding this comment.
I fully agree with all these changes! Actually wanted to do the same 😄. Feel free to merge from me. You wanted to remove the first commit?
Member
Author
|
I don't mind; it's just this and your PR conflict over that bit. |
Member
Author
|
Okay, I'll merge this. It would be nice to have my first commit merged then your work on top of that I guess. |
This was referenced Mar 1, 2018
pitdicker
pushed a commit
that referenced
this pull request
Apr 4, 2018
Small changes from experimental branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a collection of small changes from my master branch, plus one more (new module for EntropyRng).
CryptoRng— also discussed, and requested by a few people even though it neither does nor guarantees anything