Deprecate gen_iter and add iteration examples#286
Merged
pitdicker merged 1 commit intorust-random:masterfrom Mar 7, 2018
Merged
Deprecate gen_iter and add iteration examples#286pitdicker merged 1 commit intorust-random:masterfrom
pitdicker merged 1 commit intorust-random:masterfrom
Conversation
Contributor
|
Looks good to me! A bit sad for the time you spent figuring out and testing alternatives... Shall I try to merge? |
Member
Author
|
Speaking of alternatives, there's still all your FP code in my experimental branch... have to figure out whether we'll use that at some point. |
Contributor
|
You could always add some convenience method in the future, so roughly like: I wrote |
This was referenced Mar 7, 2018
pitdicker
added a commit
that referenced
this pull request
Apr 4, 2018
Deprecate gen_iter and add iteration examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #275, these changes are all that we need, I think.
I put this documentation on the
Rngtrait; I'm not quite sure if that's the best option. The library documentation at the top iflib.rscould also be revised, potentially.