Have OsRng impl CryptoRng#414
Have OsRng impl CryptoRng#414pitdicker merged 1 commit intorust-random:masterfrom mrecachinas:osrng-impl-cryptorng
Conversation
pitdicker
left a comment
There was a problem hiding this comment.
@mrecachinas Thank you for the PR!
I also believe this is it 😄.
But let's wait and see if @dhardy agrees.
|
Yes it is; thank you @mrecachinas. My only concern is that the "crypto quality" of the source is up to each implementation to assure, therefore it seems like perhaps we should do Are all implementations crypto-grade? I think they are all supposed to be; system-specific caveats are beyond the scope of this code so long as we document which sources we use (which @pitdicker already did). So yes, lets merge this. |
We assume so in other places, like |
Addresses #412.
I looked through the others and it seemed like this is just a trait addition, but no methods are required. Let me know if this does require something else.