Merged
Conversation
Member
|
I guess this lets people We opted to keep One suggestion: add brief documentation on this implementation and on |
dhardy
reviewed
Dec 5, 2018
33e61ea to
9cbba58
Compare
dhardy
approved these changes
Dec 6, 2018
Member
|
WASM fails us again 🙁 |
Contributor
Author
|
Oh? So |
Member
|
I suspect the test is failing on master too? I restarted it: https://travis-ci.org/rust-random/rand/builds/459690582 |
Member
9cbba58 to
57c54bb
Compare
Contributor
Author
|
We'll see if that works then. I suppose if anyone needs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Appears harmless. I'm unsure if this actually helps anything, especially since doing this for
OsRngrequiresunwrap, butRandomState: Defaultthough so..