Conversation
Contributor
|
This will allow us to get rid of all build scripts and the I agree that we should wait with upgrading to Edition 2018, which is more invasive. |
Member
Author
|
There are still small conflicts with #761; easier to do that afterwards. |
vks
approved these changes
Mar 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase the minimum supported Rustc version to 1.32.0.
Closes #719. Required for #761.
This has been discussed in #719. The consensus appears to be that nobody cares enough to request support for older compilers, thus it makes sense to take advantage of modern features. This is a last chance to raise objections, although Rand 0.6.x will likely continue to support 1.22.
This PR does not clean up build scripts,
cfgitems or switch to Edition 2018. I suggest we do not do this yet to avoid conflicts with #761 and work ingetrandom.