Merged
Conversation
barabadzhi
approved these changes
Apr 22, 2019
barabadzhi
left a comment
barabadzhi
left a comment
There was a problem hiding this comment.
The only thing I'd recommend is to decouple Pert from triangular.rs.
It has nothing to do with Triangular (except Beta origins)
and deserves it's own pert.rs. 🙂
rand_distr/src/triangular.rs
Outdated
|
|
||
| /// Set up the PERT distribution with defined `min`, `max`, `mode` and | ||
| /// `shape`. | ||
| pub fn new_shape(min: f64, max: f64, mode: f64, shape: f64) -> Result<Pert, PertError> { |
Member
Author
|
Rebased and reorganised commits, moved Pert distr to a new file, renamed |
vks
approved these changes
Apr 23, 2019
benjamin-lieser
pushed a commit
to benjamin-lieser/rand
that referenced
this pull request
Feb 5, 2025
Add PERT distribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #778 @barabadzhi can you review?
Testing is incomplete, as with most distributions. We need to add code for histogram/PDF testing.
Error types may see additional tweaking before the next release, but I think this will do for now @vks?