Skip to content

WIP - Add positions to mouse click events.#1289

Closed
icefoxen wants to merge 1 commit into
rust-windowing:masterfrom
icefoxen:heckin_mouse_click_positions
Closed

WIP - Add positions to mouse click events.#1289
icefoxen wants to merge 1 commit into
rust-windowing:masterfrom
icefoxen:heckin_mouse_click_positions

Conversation

@icefoxen
Copy link
Copy Markdown
Contributor

@icefoxen icefoxen commented Nov 26, 2019 •
edited
Loading

For the sake of argument. And catharsis. Addresses issue #883 for some platforms, so I can see how much work it actually takes. Not implemented for macos 'cause I don't have a way to test it.

  • Tested on all platforms changed -- Haven't tested on Windows yet.
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • cargo doc builds successfully
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@icefoxen
Add positions to mouse click events.
5213d1f 
For the sake of argument.  And catharsis.
elliegoldstein
elliegoldstein approved these changes Nov 27, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@elliegoldstein elliegoldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can only speak for the web platform, but I wouldn't be opposed to this. It maps to the browser input model cleanly and solves a fairly large user papercut.

@chelmich
Copy link
Copy Markdown
Contributor

chelmich commented Nov 27, 2019

Tested on Windows 10. Works as intended.

@goddessfreya goddessfreya added DS - android Affects the Android backend DS - uikit Affects the UIKit backend (iOS, tvOS, watchOS, visionOS) DS - appkit Affects the AppKit/macOS backend DS - wayland Affects the Wayland backend, or generally free Unix platforms DS - web Affects the Web backend (WebAssembly/WASM) DS - win32 Affects the Win32/Windows backend DS - x11 Affects the X11 backend, or generally free Unix platforms C - in progress Implementation is proceeding smoothly and removed DS - android Affects the Android backend DS - uikit Affects the UIKit backend (iOS, tvOS, watchOS, visionOS) labels Nov 28, 2019
@M-Adoo
Copy link
Copy Markdown

M-Adoo commented Jun 16, 2020

Any progress on this?

@daxpedda
Copy link
Copy Markdown
Member

daxpedda commented Jun 2, 2023

I will close this as it's unmaintained and needs a serious rebase after #2662.
Would be happy to review a renewal!

Continues to be tracked in #883.

@daxpedda daxpedda closed this Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@elliegoldstein elliegoldstein elliegoldstein approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

C - in progress Implementation is proceeding smoothly DS - appkit Affects the AppKit/macOS backend DS - wayland Affects the Wayland backend, or generally free Unix platforms DS - web Affects the Web backend (WebAssembly/WASM) DS - win32 Affects the Win32/Windows backend DS - x11 Affects the X11 backend, or generally free Unix platforms

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@icefoxen @chelmich @M-Adoo @daxpedda @elliegoldstein @goddessfreya