Fix run_return in MacOS#1321
Merged
Merged
Conversation
goddessfreya
added
DS - appkit
Contributor
|
r? @aleksijuvani or @vbogaevsky |
hatoo
force-pushed
the
fix-macos-run_return
branch
from
d221d2d to
98a5542
Compare
ghost
approved these changes
Dec 19, 2019
vbogaevsky
approved these changes
Dec 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo fmthas been run on this branchcargo docbuilds successfullyCHANGELOG.mdif knowledge of this change could be valuable to usersThis PR fixes #1242 while keeping #1117 fixed.
According to https://stackoverflow.com/questions/48041279/stopping-the-nsapplication-main-event-loop a UI event must be happening to stop event loop actually.
So I chose to modify the main window's title to activate
stop.