fix issues in wait_until_time_or_msg function#1423
Merged
Conversation
goddessfreya
added
DS - win32
filnet
force-pushed
the
fix-wait-until-time-or-msg
branch
from
cccb931 to
eb491b4
Compare
also removed unused return value
filnet
force-pushed
the
fix-wait-until-time-or-msg
branch
from
eb491b4 to
c8591aa
Compare
Osspial
approved these changes
Feb 19, 2020
Contributor
Osspial
left a comment
Osspial
left a comment
There was a problem hiding this comment.
Looks good. Thanks for catching this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would wait for events when now == wait_untill
cargo fmthas been run on this branchcargo docbuilds successfullyCHANGELOG.mdif knowledge of this change could be valuable to users