Implement run_embedded and schedule_modal_fn on Windows#1508
Draft
Osspial wants to merge 4 commits into
Draft
Conversation
|
@Osspial -- this is really neat! I wanted to share some work I've been doing to get child window support for MacOS. The key things I've added is a In any case, I've plumbed these changes into a glutin branch and was successfully able to create child windows in my DAW host. I should note that I'm not a GUI dev, and I'm sure I'm doing something horrible unsafe on this branch; however, it does sketch out a rough prototype: I'm totally fine updating my branch to use the same or similar API. What's your feeling on the direction here, re child windows? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo fmthas been run on this branchcargo docbuilds successfullyCHANGELOG.mdif knowledge of this change could be valuable to usersImplements request 2 in #159 (comment) and the API mentioned in #638 (comment). This brings us halfway to where we need to be to allow users to create DAW plugins on Windows, the other half being to implement embedded windows as discussed in #403 and #159.
This is a draft PR because it depends heavily on the work in #1496.