On Windows, fix bug causing mouse capture to not be released.#1797
Merged
msiglreith merged 2 commits intoDec 15, 2020
Conversation
Member
|
I tried your changes, and they seem to fix the issue. |
msiglreith
approved these changes
Dec 14, 2020
Member
|
I must admit that I only tested whether this PR fixed #1796 without checking for regressions. I've now discovered that doing the following seems to cause a deadlock:
|
maroider
added a commit
to maroider/winit
that referenced
this pull request
Jan 18, 2021
The issue was caused by calling SetCapture on a window which already had the capture. The WM_CAPTURECHANGED handler assumed that it would only run if the capture was lost, but that wasn't the case. This made the handler to try to lock the window state mutex while it was already locked. The issue was introduced in rust-windowing#1797 (932cbe4).
8 tasks
maroider
added a commit
to maroider/winit
that referenced
this pull request
Jan 18, 2021
The issue was caused by calling SetCapture on a window which already had the capture. The WM_CAPTURECHANGED handler assumed that it would only run if the capture was lost, but that wasn't the case. This made the handler to try to lock the window state mutex while it was already locked. The issue was introduced in rust-windowing#1797 (932cbe4).
msiglreith
pushed a commit
that referenced
this pull request
Jan 19, 2021
The issue was caused by calling SetCapture on a window which already had the capture. The WM_CAPTURECHANGED handler assumed that it would only run if the capture was lost, but that wasn't the case. This made the handler to try to lock the window state mutex while it was already locked. The issue was introduced in #1797 (932cbe4).
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo fmthas been run on this branchcargo docbuilds successfullyCHANGELOG.mdif knowledge of this change could be valuable to usersFixes #1796