Skip to content

Fix HINSTANCE returned by raw_window_handle on 64 bit Windows#1841

Merged
msiglreith merged 1 commit into
rust-windowing:masterfrom
madsmtm:fix-windows-hinstance
Jan 28, 2021
Merged

Fix HINSTANCE returned by raw_window_handle on 64 bit Windows#1841
msiglreith merged 1 commit into
rust-windowing:masterfrom
madsmtm:fix-windows-hinstance

Conversation

@madsmtm
Copy link
Copy Markdown
Member

@madsmtm madsmtm commented Jan 26, 2021

  • Tested on all platforms changed
    • Tested with x86_64-pc-windows-gnu, but can't get my build system to produce a 32bit version, so can't test that :/
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • cargo doc builds successfully
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
    • I didn't add it to the changelog since this is a very small fix.
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

We previously retrieved the value using GetWindowLongW, but the documentation explicity says that GetWindowLongPtrW should be used for pointers and handles (which is what we're fetching).

Copy link
Copy Markdown
Member

@msiglreith msiglreith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@msiglreith msiglreith merged commit f79c01b into rust-windowing:master Jan 28, 2021
@madsmtm madsmtm deleted the fix-windows-hinstance branch December 1, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants