Mac: Redraw immediately to prevent shaking on window resize#1901
Merged
Conversation
Contributor
|
At a first glance this seems to be related to or a duplicate of #1812, but I'm going to give a proper review later. |
Contributor
|
I was wrong, this addresses different problem than #1812. |
ArturKovacs
suggested changes
Apr 5, 2021
Contributor
ArturKovacs
left a comment
ArturKovacs
left a comment
There was a problem hiding this comment.
This looks perfect, but please add an entry to the CHANGELOG.md file, something like:
- On macOS, emit `RedrawRequested` events while the window is being resized.
Contributor
Author
|
Alright, and thanks for your review. |
maroider
reviewed
Apr 6, 2021
Co-authored-by: Markus Røyset <maroider@protonmail.com>
This was referenced Apr 17, 2021
5 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1837, gfx-rs/wgpu-rs#536, rust-windowing/glutin#1340, servo/webrender#1640