macOS: Fix emitting Event::LoopDestroyed on CMD+Q / pressing Quit in the menu bar#2221
Closed
madsmtm wants to merge 2 commits into
Closed
macOS: Fix emitting Event::LoopDestroyed on CMD+Q / pressing Quit in the menu bar#2221madsmtm wants to merge 2 commits into
Event::LoopDestroyed on CMD+Q / pressing Quit in the menu bar#2221madsmtm wants to merge 2 commits into
Conversation
madsmtm
added
B - bug
Contributor
|
I don't know of any macOS apps where using cmd-q or [App] -> Quit doesn't terminate the entire program, however |
Member
Author
Yeah, you're right, we'll go with your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1998
Alternatively we could do #2073 - we might still want to do that, since it makes our cleanup more robust, but I think there is merit in using
stop:overterminate:, since it would allow applications usingrun_returnto continue running.CHANGELOG.mdif knowledge of this change could be valuable to usersUpdated documentation to reflect any user-facing changes, including notes of platform-specific behaviorCreated or updated an example program if it would help users understand this functionalityUpdated feature matrix, if new features were added or implemented