Skip to content

macOS disallow_highdpi will set explicity the value to avoid the SO value by default #2339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
madsmtm merged 5 commits into from
Jun 16, 2022
Merged

macOS disallow_highdpi will set explicity the value to avoid the SO value by default #2339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b6686c9
disallow_highdpi will set explicity the value on macos to avoid the S…
Nazariglez Jun 15, 2022
e162b2b
typo fixes
Nazariglez Jun 16, 2022
d1cff25
added the fix to with_disallow_dpi to the changelog
Nazariglez Jun 16, 2022
cca5fd4
Merge branch 'master' of github.com:Nazariglez/winit
Nazariglez Jun 16, 2022
881a2d8
Update CHANGELOG.md
Nazariglez Jun 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ And please only add new entries to the top of this list, right below the `# Unre
- Implemented `Eq` for `Fullscreen`, `Theme`, and `UserAttentionType`.
- **Breaking:** `Window::set_cursor_grab` now accepts `CursorGrabMode` to control grabbing behavior.
- On Wayland, add support for `Window::set_cursor_position`.
- Fix on macOS `WindowBuilder::with_disallow_hidpi`, setting true or false by the user no matter the SO default value.

# 0.26.1 (2022-01-05)

Expand Down
5 changes: 5 additions & 0 deletions src/platform_impl/macos/window.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,13 @@ unsafe fn create_view(
) -> Option<(IdRef, Weak<Mutex<CursorState>>)> {
let (ns_view, cursor_state) = new_view(ns_window);
ns_view.non_nil().map(|ns_view| {
// The default value of `setWantsBestResolutionOpenGLSurface:` was `false` until
// macos 10.14 and `true` after 10.15, we should set it to `YES` or `NO` to avoid
// always the default system value in favour of the user's code
if !pl_attribs.disallow_hidpi {
ns_view.setWantsBestResolutionOpenGLSurface_(YES);
} else {
ns_view.setWantsBestResolutionOpenGLSurface_(NO);
}

// On Mojave, views automatically become layer-backed shortly after being added to
Expand Down