Update sctk-adwaita#2438
Merged
Merged
Conversation
kchibisov
requested changes
Aug 23, 2022
Member
kchibisov
left a comment
kchibisov
left a comment
There was a problem hiding this comment.
We could add as an option, but I'd prefer crossfont to have native looks of the fonts instead of whatever ab_glyph is using. I agree that we should change default for that. It also uses some random hardcoded font instead of system font, like crossfont does.
But for default rust windowing library using rust font renderer is likely easier to test and cross build since most of the users don't care.
Also you should update the CI script to remove all the extra deps installing.
kchibisov
reviewed
Aug 23, 2022
daxpedda
force-pushed
the
update-sctk-adwaita
branch
from
3dfa1bd to
83c9d3f
Compare
kchibisov
reviewed
Aug 23, 2022
kchibisov
requested changes
Aug 23, 2022
daxpedda
force-pushed
the
update-sctk-adwaita
branch
from
336b7e3 to
3fae355
Compare
kchibisov
requested changes
Aug 23, 2022
daxpedda
force-pushed
the
update-sctk-adwaita
branch
from
3fae355 to
967ec6e
Compare
kchibisov
approved these changes
Aug 23, 2022
Member
kchibisov
left a comment
kchibisov
left a comment
There was a problem hiding this comment.
Should be fine that way, I guess.
daxpedda
force-pushed
the
update-sctk-adwaita
branch
from
967ec6e to
46f6bc9
Compare
alexheretic
reviewed
Aug 23, 2022
3 tasks
kchibisov
requested changes
Aug 24, 2022
Member
kchibisov
left a comment
kchibisov
left a comment
There was a problem hiding this comment.
Should add default-features = false to sctk-adwaita.
daxpedda
force-pushed
the
update-sctk-adwaita
branch
from
46f6bc9 to
eec92b5
Compare
daxpedda
requested review from
alexheretic and
kchibisov
and removed request for
alexheretic and
kchibisov
kchibisov
approved these changes
Aug 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sctk-adwaitanow usesab_glyphinstead ofcrossfont. As far as I can tell this isn't a breaking change.I'm not sure if some users would prefer
crossfontoverab_glyph. Alternatively we could add another crate feature for that? I think it would have been better to removewayland-csd-adwaita-notitleand addwayland-csd-adwaita-ab-glyphandwayland-csd-adwaita-crossfontinstead, but it's too late for that now.Fixes #2373.