feat(x11): Add Window::drag_resize_window#2515
Conversation
c3c339b to
b06293f
Compare
|
Winit supports drag_window_resize without any addition in current master on Apple M1. Probably shouldn't panic on drag_window_resize and just give a warning to developers. Screen.Recording.2022-10-16.at.8.19.22.PM.mov |
|
There isn't a panic in the source code. It is simply stating that it's not supported by winit |
|
Cool. Just wanted to add that Apple supports this out-of-the-box right now without calling this function. |
kchibisov
left a comment
There was a problem hiding this comment.
You should remove the parts saying that Wayland is impelemented since it's cleary not.
|
Which parts mention that Wayland is supported? I did already update the platform-specific table to only show that X11 is supported. |
81b0fb1 to
de103d9
Compare
7827fd3 to
10e75bd
Compare
kchibisov
left a comment
There was a problem hiding this comment.
Looks fine, just some minor notes.
|
Rebased with conflicts resolved. The period added to the changelog entry. |
|
Thanks, I somehow forgot that this PR existed. |
CHANGELOG.mdif knowledge of this change could be valuable to usersImplements functionality required to resolve #725 for X11. Uses the example from #2003. Only supports X11 on Linux for now. Wayland support will require a future release of sctk with the additional protocol added to the API. And there's some substantial changes in sctk at the moment so upgrading this library will be a bit of a chore. Code from #2003 for Windows support could be added on top of this.