Resume propagation of events#2873
Merged
Merged
Conversation
a09d4c9 to
6de189f
Compare
6de189f to
4b528f9
Compare
Member
Author
I actually had to fix it in a different way. The web backend can't send events from multiple handlers at the same time, it has to restart the event loop every time. So I'm trying as much as possible to coalesce as many events as possible. So for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure why
stopPropagation()is being used, maybe becausepreventDefault()wasn't used back then. In any case, I don't think we want to prevent parents to receive events if they want to.The call to
cancelBubbledoesn't do anything, it's a getter.EDIT: See #2873 (comment), I decided to keep
stopPropagation()for now.