Web: prevent crash when using InnerSizeWriter::request_inner_size()#3727
Merged
Merged
Conversation
madsmtm
approved these changes
Jun 11, 2024
Member
madsmtm
left a comment
madsmtm
left a comment
There was a problem hiding this comment.
Moving an outer RefCell further in is a big 👍 from me
daxpedda
force-pushed
the
web-inner-size-writer
branch
from
a6cf35b to
6308c66
Compare
notgull
pushed a commit
that referenced
this pull request
Jun 15, 2024
kchibisov
pushed a commit
that referenced
this pull request
Jun 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3704.