Avoid path when importing modules#3755
Merged
Merged
Conversation
Rust tooling generally works better this way. This includes rust-analyzer, but more noticeably the output from `tracing` typically prints the module path, which did not correspond to the actual file system before. Concretely, tracing output from the macOS backend changes from printing: `winit::platform_impl::platform::util` To printing: `winit::platform_impl::macos::util`
notgull
approved these changes
Jun 24, 2024
Contributor
notgull
left a comment
notgull
left a comment
There was a problem hiding this comment.
This pull request has been fact checked by true notgull patriots (✔️)
daxpedda
requested changes
Jun 24, 2024
Member
daxpedda
left a comment
daxpedda
left a comment
There was a problem hiding this comment.
I very much agree with this change, but I wish there was a lint for using use self::module;.
Can make a PR for my nit myself later.
madsmtm
added a commit
that referenced
this pull request
Jun 24, 2024
kchibisov
pushed a commit
that referenced
this pull request
Jul 16, 2024
Rust tooling generally works better this way. This includes rust-analyzer, but more noticeably the output from `tracing` typically prints the module path, which did not correspond to the actual file system before. Concretely, tracing output from the macOS backend changes from printing: `winit::platform_impl::platform::util` To printing: `winit::platform_impl::macos::util`
kchibisov
pushed a commit
that referenced
this pull request
Jul 16, 2024
Rust tooling generally works better this way. This includes rust-analyzer, but more noticeably the output from `tracing` typically prints the module path, which did not correspond to the actual file system before. Concretely, tracing output from the macOS backend changes from printing: `winit::platform_impl::platform::util` To printing: `winit::platform_impl::macos::util`
kchibisov
pushed a commit
that referenced
this pull request
Jul 16, 2024
Rust tooling generally works better this way. This includes rust-analyzer, but more noticeably the output from `tracing` typically prints the module path, which did not correspond to the actual file system before. Concretely, tracing output from the macOS backend changes from printing: `winit::platform_impl::platform::util` To printing: `winit::platform_impl::macos::util`
kchibisov
pushed a commit
that referenced
this pull request
Jul 16, 2024
Rust tooling generally works better this way. This includes rust-analyzer, but more noticeably the output from `tracing` typically prints the module path, which did not correspond to the actual file system before. Concretely, tracing output from the macOS backend changes from printing: `winit::platform_impl::platform::util` To printing: `winit::platform_impl::macos::util`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust tooling generally works better this way. This includes rust-analyzer, but more noticeably the output from
tracingtypically prints the module path, which did not correspond to the actual file system before.Concretely, tracing output from the macOS backend changes from printing
winit::platform_impl::platform::utilto printingwinit::platform_impl::macos::util.