macOS: Store UUID in MonitorHandle instead of CGDirectDisplayID#4167
Merged
Conversation
madsmtm
added
B - bug
madsmtm
force-pushed
the
madsmtm/macos-monitor-handle-uuid
branch
2 times, most recently
from
b3ee234 to
7aa7092
Compare
|
Is this something that would also affect iOS? Anecdotally I've had a lot of crashes in my app when resuming after a long period of time |
Member
Author
I don't think so, the |
Merged
madsmtm
force-pushed
the
madsmtm/macos-monitor-handle-uuid
branch
from
7aa7092 to
bba577b
Compare
The monitor UUID is what actually represents the monitor, CGDirectDisplayID is closer in correspondence to a specific framebuffer.
madsmtm
force-pushed
the
madsmtm/macos-monitor-handle-uuid
branch
from
bba577b to
d6c7dc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The monitor UUID is what actually represents the monitor,
CGDirectDisplayIDis closer in correspondence to a configured framebuffer. We've already been doing comparisons on the UUID for a while, let's finish this by also storing the UUID.Fixes #4166.
I have created a branch for backporting this onto v0.30 here.
changelogmodule if knowledge of this change could be valuable to users