Skip to content

wayland/fix: crash due consequent calls to set_cursor_grab#4196

Merged
kchibisov merged 1 commit into
rust-windowing:masterfrom
kchibisov:wayland-confine-pointer
Apr 20, 2025
Merged

wayland/fix: crash due consequent calls to set_cursor_grab#4196
kchibisov merged 1 commit into
rust-windowing:masterfrom
kchibisov:wayland-confine-pointer

Conversation

@kchibisov
Copy link
Copy Markdown
Member

Only mark that the grab was applied when it actually got applied. Previously there was an issue with grab being marked as applied without a pointer over the window, when in reality it wasn't.

Fixes #4073.

--

Could you test this, @Jupeyy? It's a bit different approach, but should also solve it.

@kchibisov kchibisov force-pushed the wayland-confine-pointer branch from e1cb861 to ede82ba Compare April 20, 2025 01:48
Copy link
Copy Markdown

@Jupeyy Jupeyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as well, thanks again.

Only mark that the grab was applied when it actually got applied.
Previously there was an issue with grab being marked as applied without
a pointer over the window, when in reality it wasn't.

Fixes rust-windowing#4073.
@kchibisov kchibisov force-pushed the wayland-confine-pointer branch from ede82ba to a5f2a57 Compare April 20, 2025 09:45
@kchibisov kchibisov merged commit 6c214e7 into rust-windowing:master Apr 20, 2025
57 checks passed
@madsmtm madsmtm added this to the Version 0.30.10 milestone Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

zwp_pointer_constraints_v1#19: error 1: the surface is already constrained

3 participants