Draft: [EXPERIMENT] begin adding "async" versions of trait/impls #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an experimentation branch. The way I duplicated code to """quickly""" have an async impl is a terrible way to do it. Full code duplication is never a good option. My goal is to reach a state of rustic/rustic_core/rustic_backend to experiment on the async implementations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experimentation branch.
The way I duplicated code to """quickly""" have an async impl is a terrible way to do it.
To me full code duplication is never a good option.
My goal is to reach a state of rustic/rustic_core/rustic_backend to experiment on the async implementations.
This might be a step towards a long term architectural change that could solve issues like rustic-rs/rustic#1181 and possibly enhance performances? (yet to be measured^^)
Do you find interesting that I keep on going with this experimentation?