Exclude development scripts from published package#320
Merged
djc merged 1 commit intorustls:mainfrom Jan 1, 2026
Merged
Conversation
During a dependency review we noticed that the hyper-rustls crate includes various development scripts. These development scripts shouldn't be there as they might, at some point become problematic. As of now they prevent any downstream user from enabling the `[bans.build.interpreted]` option of cargo deny. I opted for using an explicit include list instead of an exclude list to prevent these files from being included in the published packages to make sure that everything that's included is an conscious choice.
djc
approved these changes
Dec 16, 2025
decathorpe
reviewed
Apr 14, 2026
| homepage = "https://github.com/rustls/hyper-rustls" | ||
| repository = "https://github.com/rustls/hyper-rustls" | ||
| documentation = "https://docs.rs/hyper-rustls/" | ||
| include = ["Cargo.toml", "LICENSE-MIT", "LICENSE-APACHE", "LICENSE-ICS", "README.md", "src/**/*.rs"] |
There was a problem hiding this comment.
There's a typo here - it says "LICENSE-ICS" but it should be "LICENSE-ISC".
This has resulted in the latest release not including the ISC license text.
Member
There was a problem hiding this comment.
🤦 Oops. Thanks for catching. Addressing in #340. Seems worth a point release to fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During a dependency review we noticed that the hyper-rustls crate includes various development scripts. These development scripts shouldn't be there as they might, at some point become problematic. As of now they prevent any downstream user from enabling the
[bans.build.interpreted]option of cargo deny.I opted for using an explicit include list instead of an exclude list to prevent these files from being included in the published packages to make sure that everything that's included is an conscious choice.