Enable rustls_native_certs::load_native_certs on FreeBSD#105
Merged
djc merged 2 commits intorustls:mainfrom Jun 26, 2024
Merged
Enable rustls_native_certs::load_native_certs on FreeBSD#105djc merged 2 commits intorustls:mainfrom
rustls_native_certs::load_native_certs on FreeBSD#105djc merged 2 commits intorustls:mainfrom
Conversation
cpu
reviewed
Jun 26, 2024
The `rustls-native-certs` crate doesn't support WASM (there's no native cert bundle or platform verifier). The existing conditional dependency import in `Cargo.toml` allowed the `unix` platform family that may include a wasm target arch target. This commit updates it to exclude these targets.
cpu
approved these changes
Jun 26, 2024
Member
cpu
left a comment
cpu
left a comment
There was a problem hiding this comment.
LGTM, but since I've pushed commits I won't merge it myself.
djc
approved these changes
Jun 26, 2024
ctz
approved these changes
Jun 26, 2024
Member
ctz
left a comment
ctz
left a comment
There was a problem hiding this comment.
The more I think about it I'm not sure the original cfg expression made sense (linux, but not on wasm32 -- eh?) This is better.
Member
|
Thanks @rami3l ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #104, as requested in #104 (comment).
Tested in rust-lang/rustup#3912 with positive outcome.
cc @ctz @cpu