Forward vectored writes#45
Forward vectored writes#45quininer merged 4 commits intorustls:mainfrom M4SS-Code:forward-vectored-writes
Conversation
|
Tests seem to get stuck every once in a while. It also happens on |
It seems that due to |
|
As a performance improvement that doesn't have to block 0.23 release, I'll try to rewrite this test over the weekend (using rustls instead of openssl). |
|
This early data situation looks weird. Even if I remove the |
I've decided to try rewriting it myself. I opted for simplicity and left the TCP connection doing the bridging between the sync and async world. |
|
I have a branch based on tokio-rustls server, but I think it would be nice to use a sync implement. thank you. |
| use std::io::Write; | ||
|
|
||
| // write early data | ||
| if let Some(mut early_data) = stream.session.early_data() { |
There was a problem hiding this comment.
It's a little different than what I thought it would be, but it's also good.
I actually think it should be outside the function.
|
Thank you! |
* Migrate early-data test to rustls * Replace `match` with `if let` on `TlsState::EarlyData` * Extract client early data handling * Forward vectored writes
Allows making use of rustls/rustls#1640.
Supersedes #25
I've also run tests with #44 and it seems to work correctly.
Closes #25
Closes #26