fix: check for ErrorKind::WouldBlock in MidHandshake::SendAlert poll#47
Merged
quininer merged 1 commit intorustls:mainfrom Mar 6, 2024
jbr:send-alert-would-block
Merged
fix: check for ErrorKind::WouldBlock in MidHandshake::SendAlert poll#47quininer merged 1 commit intorustls:mainfrom jbr:send-alert-would-block
quininer merged 1 commit intorustls:mainfrom
jbr:send-alert-would-block
Conversation
Contributor
Author
|
It's worth noting that the LazyConfigAcceptor alert.write has the same concern, but that one is at least annotated as best effort. I think we'd want to throw an |
This was referenced Mar 5, 2024
Member
|
Thank you! |
Merged
takumi-earth
pushed a commit
to earthlings-dev/tokio-rustls
that referenced
this pull request
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identified by comparing the implementation of rustls/futures-rustls#9 to #44. Previous to this PR, we do not necessarily poll the alert.write to completion