Merged
Conversation
djc
approved these changes
Apr 2, 2026
Member
djc
left a comment
djc
left a comment
There was a problem hiding this comment.
Looks good, although I think we should call out that it is unmaintained.
xizheyin
commented
Apr 2, 2026
|
|
||
| DynFuture is unsound because its Drop implementation transmutes a trait-object reference into unrelated reference types, which constructs an invalid reference from trait object metadata. | ||
|
|
||
| This issue was reproduced against `dyn-future` 3.0.4 under Miri. And the crate is unmaintained. |
Contributor
Author
There was a problem hiding this comment.
I point out that the crate is unmaintained in this version
djc
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #2595 cc @djc