Skip to content

Landmarks should be labelled #8

@blissd

Description

@blissd

The landmarks for a face are returned as a Vec<f32, f32> which does not tell users of the API what any particular landmark is. Could the API return an enum for each landmark indicating what the point identifies? For example:

pub enum LandmarkType {
  LeftEye(f32, f32),
  RightEye(f32, f32),
 ...
}

or maybe:

pub enum LandmarkType {
  LeftEye(f32, f32),
  RightEye(f32, f32),
 ...
}

pub struct Landmark(LandmarkType, f32, f32);

Or, simply name the landmarks in the Face struct:

pub struct Face {
  ...
  right_eye: Option<(f32, f32)>;
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions