Skip to content

fix/docker: pass args directly to binary instead of shell #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fuleinist wants to merge 1 commit into from
+11 −6
Closed

fix/docker: pass args directly to binary instead of shell #407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions docker/Dockerfile.rust
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,12 @@ ENV RUST_LOG=info
# Override at runtime: docker run -e CSI_SOURCE=esp32 ...
ENV CSI_SOURCE=auto

ENTRYPOINT ["/bin/sh", "-c"]
# Shell-form CMD allows $CSI_SOURCE to be substituted at container start.
# The ENV default above (CSI_SOURCE=auto) applies when the variable is unset.
CMD ["/app/sensing-server --source ${CSI_SOURCE} --tick-ms 100 --ui-path /app/ui --http-port 3000 --ws-port 3001"]
ENTRYPOINT ["/app/sensing-server"]
# Exec-form CMD allows arguments after the image name to reach the binary directly.
# Use -e CSI_SOURCE=... to control the data source at runtime.
# Examples:
# docker run ruvnet/wifi-densepose:latest # auto mode (default)
# docker run -e CSI_SOURCE=simulated ruvnet/wifi-densepose:latest # synthetic data
# docker run -e CSI_SOURCE=esp32 ruvnet/wifi-densepose:latest # real ESP32 hardware
# docker run ruvnet/wifi-densepose:latest --source simulated # equivalent to above
CMD []
4 changes: 2 additions & 2 deletions docker/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ services:
# wifi — use host Wi-Fi RSSI/scan data (Windows netsh)
# simulated — generate synthetic CSI data (no hardware required)
- CSI_SOURCE=${CSI_SOURCE:-auto}
# command is passed as arguments to ENTRYPOINT (/bin/sh -c), so $CSI_SOURCE is expanded by the shell.
command: ["/app/sensing-server --source ${CSI_SOURCE:-auto} --tick-ms 100 --ui-path /app/ui --http-port 3000 --ws-port 3001"]
# command args are passed directly to the binary; CSI_SOURCE env var is read by the server.
command: ["/app/sensing-server", "--source", "${CSI_SOURCE:-auto}", "--tick-ms", "100", "--ui-path", "/app/ui", "--http-port", "3000", "--ws-port", "3001"]

python-sensing:
build:
Expand Down