Conversation
…415) mat, sensing-server, and train all depended on signal with default features enabled, which pulled ndarray-linalg → openblas-src → vcpkg/system-BLAS through the entire workspace. --no-default-features at the workspace root could not opt out of BLAS, breaking cargo build / cargo test on Windows without vcpkg. Set default-features = false on the signal dep in all three consumers so the flag actually propagates. Also gate signal::ruvsense::field_model::tests ::test_estimate_occupancy_noise_only with #[cfg(feature = "eigenvalue")] — the test unwraps a NotCalibrated stub when eigenvalue is compiled out. Validated: cargo test --workspace --no-default-features → 1,538 passed, 0 failed, 8 ignored. ESP32-S3 on COM7 still streams live CSI. Co-Authored-By: claude-flow <ruv@ruv.net>
This was referenced Apr 25, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #366 and the active half of #415:
cargo build --workspace --no-default-featuresandcargo test --workspace --no-default-featuresnow succeed on Windows without vcpkg/openblas.Root cause
wifi-densepose-mat,wifi-densepose-sensing-server, andwifi-densepose-trainall depended onwifi-densepose-signalwith default features enabled, which means signal'sdefault = [\"eigenvalue\"]pulledndarray-linalg→openblas-srcthrough the entire workspace.--no-default-featuresat the workspace root only applies to the target crate; transitive default features stay on. The CLAUDE.md-recommended Windows build path (cargo test --workspace --no-default-features) therefore could not actually opt out of BLAS.Fix
Three one-liners on the signal dependency:
…in
mat/Cargo.toml,sensing-server/Cargo.toml,train/Cargo.toml. Plus one stale-test fix:The test was already failing on
mainunder--no-default-features(unwrapping theNotCalibratedstub returned when the BLAS-backed impl is compiled out) — this gate makes the workspace test claim hold true.Validation
ESP32-S3 on COM7 was running unmodified firmware throughout and continued streaming live CSI (cb #15900, RSSI −44 dBm) before, during, and after these changes — server-side fix only, no firmware impact.
Notes on user reports
The
E0432 unresolved import ruvector_mincut,E0425 CLASSES, and 5×E0499/E0502borrow errors that the user reported in #366 against v0.6.2 source code are already fixed in different ways onmain(ruvector-mincut is now declared,CLASSESwas renamed tomodel.class_names, tracker_update uses the.take()+restore pattern). What was not fixed onmainwas the BLAS propagation — that's what this PR addresses.Test plan
cargo check --workspace --no-default-featuressucceeds on Windowscargo test --workspace --no-default-features→ 1,538 passed, 0 failed🤖 Generated with claude-flow