chore: update deps#102
Merged
Merged
Conversation
Upgrades Buffer to fix bundle size increases for modules that have already upgraded to `Buffer@6.x.x` elsewhere. Also upgrades dev deps.
rvagg
approved these changes
Mar 31, 2021
Owner
rvagg
left a comment
rvagg
left a comment
There was a problem hiding this comment.
thanks @achingbrain
@mcollina I think we have to semver-major this since it's a minimum-runtime impacting change, see feross/buffer@840160f
There's another possibility of doing a "buffer": "5||6" to make it flexible because we currently don't care about the change in features but also want to fit nicely into the background of large dependency trees. But that will still default to 6.x and therefore be a breaking change in most cases.
@mcollina feel free to merge & release when you see this, my vote is for a semver-major bump with this PR as is (tho open to 5||6).
10 tasks
Collaborator
|
I would go for a semver-major bump as well. I'll see if I can get to it tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades Buffer to fix bundle size increases for modules that have
already upgraded to
Buffer@6.x.xelsewhere.Also upgrades dev deps.