-
Notifications
You must be signed in to change notification settings - Fork 105
Patch: Using inherits package instead of node inherits. #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This trims down a browserify build as well |
|
@rvagg do you need me to do something before this can get merged? |
|
@martinheidegger no, just time, there's multiple people in this repo that could object and block this so it's appropriate to leave space for any of them to pipe up. |
|
d30f8f7 & v3.0.2 |
Got it, thank you for merging it! |
|
Side question: Should I send a similar PR for the 2.x branch? |
|
@martinheidegger do you use 2.x? probably not, I'd like it to be considered long-dead. See also #103 just now. |
|
I don't use 2.x but I have seen dependencies looking like |
|
maybe leave it until someone squeaks? if you're packing with the newest webpack that throws up this problem then you're more likely to have v3 in your dependency chain. we can backport if needed but I'm not super keen on keeping ancient things alive and having more surface area for maintenance. |

Webpack (and react-native) doesn't support node globals / global modules. This pull request removes the
utilglobal dependency and replaces it withinheritswhich implements inherits just as node does, but works without globals.Note: I am sure about the version range of inherits to be used. Used "^2.0.4" for the moment.