Sync atmospheric heater "reset" gizmo #495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Comp_AtmosphericHeater` is a subtype of `CompTempControl`, but has the `CompGetGizmosExtra` method rewritten. The +/- 1/10 degrees change was working fine, as it called the synced method `InterfaceChangeTargetTemperature_NewTemp`. However, this was not the case for the reset gizmo, as it set the temperature directly. I've synced the reset gizmo for the atmospheric heater itself, so it should work fine now. Also moved the `CompTempControl` gizmo from `SyncDelegates` to `SyncMethods`, right next to where the other sync method for it was registered. I believe it should have been there to begin with, and I must have made a mistake while working through all the new and changed gizmos in 1.5.
SokyranTheDragon
added
1.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comp_AtmosphericHeateris a subtype ofCompTempControl, but has theCompGetGizmosExtramethod rewritten. The +/- 1/10 degrees change was working fine, as it called the synced methodInterfaceChangeTargetTemperature_NewTemp. However, this was not the case for the reset gizmo, as it set the temperature directly. I've synced the reset gizmo for the atmospheric heater itself, so it should work fine now.Also moved the
CompTempControlgizmo syncing fromSyncDelegatestoSyncMethods, right next to where the other sync method for the type was registered. I believe it should have been there to begin with, and I must have made a mistake while working through all the new and changed gizmos in 1.5.