Use more nameof and use Harmony to access properties rather than methods
#503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thods String constant, wherever possible (assuming I haven't missed some), were replaced by the use of `nameof`. Replaced places where properties are accessed with `AccessTools.PropertyGetter` or `AccessTools.IndexerGetter`, rather than `AccessTools.Method` by using `get_` in the method name. Also, I've changed array initialization to use collection expressions in `SyncThingFilters` class, since I was already modifying it.
…rors Not sure why (I've tried to clear my publicizer cache, etc.). It seems that, for me, Rider is refusing to acknowledge that this field is public. It still compiles fine and without any errors, however this causes annoying errors in code. So for the sake of safety (in case anyone else is going to encounter this issue) - I've decided to just revert this specific change. On top of that, one thing I did not consider at the time - rather than using reflection, we could have just replaced this with `te.m_RevealCursor = true` (if there was no issue after publicizing).
Member
Author
|
I've reverted change for Not sure why (I've tried to clear my publicizer cache, etc.). It seems that, for me, Rider is refusing to acknowledge that this field is public. It still compiles fine and without any errors, however this causes annoying errors while working on the project. So for the sake of safety (in case anyone else is going to encounter this issue) - I've decided to just revert this specific change. On top of that, one thing I did not consider at the time - rather than using reflection, we could have just replaced this with |
SokyranTheDragon
added
the
low priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String constant, wherever possible (assuming I haven't missed some), were replaced by the use of
nameof.Replaced places where properties are accessed with
AccessTools.PropertyGetterorAccessTools.IndexerGetter, rather thanAccessTools.Methodby usingget_in the method name.Also, I've changed array initialization to use collection expressions in
SyncThingFiltersclass, since I was already modifying it.