Fix for #547 #550
Merged
Fix for #547 #550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwmt#547 Mechanitor scenario desync The Pause patch is triggered during initialization of one of the starting mechs, before CurrentMap is set. Accessing CurrentMap at this point throws a NullReferenceException, which leads to a desync after map generation when the game is unpaused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue: #547
To make the solution more targeted, the TickManager.Paused patch is now explicitly disabled while a new map is being generated. Instead of a generic
currentMap == nullcheck, this usesFactionCreator.generatingMapto indicate the reason the patch is being skipped.This makes it more obvious why the guard exists and helps prevent future confusion or accidental removal.