Test PR to show CI running by ryanfkeller · Pull Request #1168 · ryanfkeller/website

ryanfkeller · 2025-11-06T01:45:42Z

Test edit 2. Please note: You must be a member of the HFLA website team in order to create pull requests. Please see our page on how to join us as a member at HFLA: https://www.hackforla.org/getting-started. Delete this message if you joined this team via onboarding.

Fixes #replace_this_text_with_the_issue_number

What changes did you make?

Why did you make the changes (we will use this info to test)?

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

I have checked this PR for CodeQL alerts and none were found.
I found CodeQL alert(s), and (select one):
- I have resolved the CodeQL alert(s) as noted
- I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
- I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)

Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

Visuals after changes are applied

github-actions · 2025-11-06T01:45:52Z

@ryanfkeller, this Pull Request is not linked to a valid issue. Above, on the first line of your PR, please link the number of the issue that you worked on using the format of 'Fixes #' + issue number, for example: Fixes #9876

Note: Do not use the number of this PR.

github-actions · 2025-11-06T01:46:04Z

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b ryanfkeller-frontend-unit-tests gh-pages
git pull https://github.com/ryanfkeller/website.git frontend-unit-tests

tests/frontend/transformers/jekyll-js-transformer.js

+
+            try {
+                if (ext === ".json") {
+                    dirData[name] = JSON.parse(fs.readFileSync(fullPath, 'utf-8'));


tests/frontend/transformers/jekyll-js-transformer.js

+                    dirData[name] = JSON.parse(fs.readFileSync(fullPath, 'utf-8'));
+                } else if (ext === '.yml' || ext === '.yaml') {
+                    // Target YMLs might use multi-doc syntax, so we need to use loadAll
+                    const ymlDocs = yaml.loadAll(fs.readFileSync(fullPath, 'utf-8'));


assets/js/utility/vrms-events.mjs

+---
+---
+
+import { filterTestEvents, sortEventsByDate } from "./vrms-events-utils.mjs";


To fix the syntax error, all non-JavaScript code (i.e., the lines containing Liquid {% ... %} or {{ ... }} and the header --- lines) should be removed from assets/js/utility/vrms-events.mjs.

Delete lines 1 and 2 containing just ---.

Remove line 6, the {% assign vrmsData = site.data.external.vrms_data %} template code.

Replace line 7, which uses Liquid to attempt in-place assignment for vrmsData, with a regular JavaScript assignment or, if the file receives vrmsData via import or an environment variable, adjust accordingly. If template-time data injection is required, it should be done elsewhere, not inside a .mjs file. Since we do not know how vrmsData should be supplied at runtime, we can assign it to an empty array or provide a placeholder with a comment to indicate where data should be provided.

The rest of the code is valid ES module JavaScript and does not require changes.

tests/frontend/integration/hamburger-nav.intg.test.js

+            </ul>
+        </div>
+    </nav>
+`


To fix this problem, we should ensure the assignment to defaultTestDom is followed by an explicit semicolon, as it is for other variable declarations and assignments in the file. This simply involves adding a semicolon immediately after the closing backtick at the end of line 20. This change maintains code style consistency and removes ambiguity regarding statement termination, without altering any program functionality.

tests/frontend/integration/hamburger-nav.intg.test.js

+
+let headerNav;
+let burgerImage;
+let burgerIcon;


To fix the problem, we should remove the declaration of the unused variable burgerIcon from the file tests/frontend/integration/hamburger-nav.intg.test.js. Specifically, line 24 (let burgerIcon;) can simply be deleted. This will improve code readability, reduce confusion, and eliminate pointless code.

tests/frontend/integration/hamburger-nav.intg.test.js

+let headerNav;
+let burgerImage;
+let burgerIcon;
+let burgerXIcon;


The best way to fix this problem is to remove the unused variable declaration for burgerXIcon at line 25 in tests/frontend/integration/hamburger-nav.intg.test.js. This does not change any existing functionality, as the variable was never assigned or read, and also makes the code cleaner and easier to maintain.

github-actions · 2025-11-06T01:52:17Z

@ryanfkeller, this Pull Request is not linked to a valid issue. Above, on the first line of your PR, please link the number of the issue that you worked on using the format of 'Fixes #' + issue number, for example: Fixes #9876

Note: Do not use the number of this PR.

github-actions · 2025-11-06T01:55:10Z

@ryanfkeller, this Pull Request is not linked to a valid issue. Above, on the first line of your PR, please link the number of the issue that you worked on using the format of 'Fixes #' + issue number, for example: Fixes #9876

Note: Do not use the number of this PR.

github-actions · 2025-11-06T01:58:54Z

@ryanfkeller, this Pull Request is not linked to a valid issue. Above, on the first line of your PR, please link the number of the issue that you worked on using the format of 'Fixes #' + issue number, for example: Fixes #9876

Note: Do not use the number of this PR.

…rla#8449) Bumps [stefanzweifel/git-auto-commit-action](https://github.com/stefanzweifel/git-auto-commit-action) from 7.0.0 to 7.1.0. - [Release notes](https://github.com/stefanzweifel/git-auto-commit-action/releases) - [Changelog](https://github.com/stefanzweifel/git-auto-commit-action/blob/master/CHANGELOG.md) - [Commits](stefanzweifel/git-auto-commit-action@v7.0.0...v7.1.0) --- updated-dependencies: - dependency-name: stefanzweifel/git-auto-commit-action dependency-version: 7.1.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

The devops repo is being renamed from https://github.com/hackforla/ops to https://github.com/hackforla/devops with this change users will be able to navigate to the renamed repo from the hfla website's communities of practice page: https://www.hackforla.org/communities-of-practice

…orla#8437) * changed program-areas to true * added program-areas to default * renamed citizen-engagement.html and moved to _layouts * made card appear based on page program area * made title reflect the page * renamed _citizen_engagement.scss file and updated import in main.scss

* update devops name 8388 * reverting to normal * redid changes for issue

@bragelbytes

Great job working on this issue @bragelbytes!

Broke testable functions out from vrms-events and current-projects into their associated -utils files. Added includeing the current-projects-utils.js script in current-projects Updated ESM-syntax vrms-events to use the extension .mjs, so it will be interpreted correctly by the test runner. Updated files that call vrms events to use the new extension.

Created hfla_test docker container that loads node:alpine for node environment testing Adds startup container commands to install dependencies required for testing, AND to launch Jest -- depending on how we want to use this, we may want to roll that back Adds a jest config that specifies where the source and test files are located, and how to map to our Jekyll transformer Adds a Jekyll transformer that processes JS files when "require" or "import" is called on them to populate both the frontmatter and inline LiquidJS statements with the real site data -- mostly useful for integration testing

Two basic unit tests with the extracted pure-logic functions Two "integration" tests, one demoing using a simulated DOMs, the other demoing testing against real Jekyll data

github-advanced-security bot found potential problems Nov 6, 2025

View reviewed changes

ryanfkeller force-pushed the frontend-unit-tests branch from 4263db8 to f4cce04 Compare November 6, 2025 01:50

ryanfkeller force-pushed the frontend-unit-tests branch from f4cce04 to 7e2793d Compare November 6, 2025 01:54

HackforLABot added 22 commits November 28, 2025 11:06

Update contributor and language data

0d23cf3

Update contributor and language data

5082a2b

Update contributor and language data

5a7dfe8

Update contributor and language data

e454592

Update Inactive Members JSON

78c3555

Update contributor and language data

fe38f14

Update contributor and language data

8b8ac4d

Update contributor and language data

65f17cf

Update contributor and language data

baa0322

Update contributor and language data

db8fa41

Update contributor and language data

4a0edd4

Update contributor and language data

b0cf07a

Update contributor and language data

ecbd842

Update contributor and language data

03db5a8

Update contributor and language data

4c30a0d

Update contributor and language data

0585f10

Update contributor and language data

dec7521

Update meeting data

897c43b

Update contributor and language data

9bb46f2

Update contributor and language data

5b01ee0

Update contributor and language data

6cf2482

Update meeting data

c2498b7

HackforLABot and others added 29 commits December 30, 2025 11:07

Update contributor and language data

615407d

Update contributor and language data

359068a

Update contributor and language data

64678e6

Update contributor and language data

89c11c7

Update contributor and language data

2476e38

Update contributor and language data

2b02e88

Update contributor and language data

d44a85c

Update contributor and language data

de99e85

Update contributor and language data

d7f43bb

Update contributor and language data

6b9420c

Update contributor and language data

82f0a4c

Update contributor and language data

a83b152

Update contributor and language data

0350323

Updated CoP DevOps Name (hackforla#8455)

177fef1

* update devops name 8388 * reverting to normal * redid changes for issue

added Jason Shi to Civic Tech Jobs page (hackforla#8459)

07ab7c7

Great job working on this issue @bragelbytes!

Adds proof-of-concept Jest tests

ceed9e4

Two basic unit tests with the extracted pure-logic functions Two "integration" tests, one demoing using a simulated DOMs, the other demoing testing against real Jekyll data

Adds PR hook to run CI when opening a PR into gh-pages

4ef7b5a

Fixes js-yaml dependency

507de4a

Resolves some CodeQL alerts

ba8494c

Another attempt at fixing the CodeQL race condition

01eca40

Breaks CI GHA into separate workflow with implicit synchronize trigger

2e234b7

Updates test names to be "active", updates js-yaml version

fee216b

Consolidates broken-out utils files in assets/js

7abb984

Removes integration tests (out of scope_

dc3c099

ryanfkeller force-pushed the frontend-unit-tests branch from 68eb481 to dc3c099 Compare January 23, 2026 03:30

@@ -1,11 +1,8 @@
-            ---
-            ---
             import { filterTestEvents, sortEventsByDate } from "./vrms-events-utils.mjs";
-            {% assign vrmsData = site.data.external.vrms_data %}
-            const vrmsData = JSON.parse(decodeURIComponent("{{ vrmsData | jsonify | uri_escape }}"));
+            // TODO: Assign vrmsData to the appropriate value at runtime
+            // Example: const vrmsData = []; // or import from an external source at runtime
+            const vrmsData = []; // Placeholder assignment. Replace with actual data as needed.
             /* vrmsDataFetch calls sortByDate function and passes filteredVrmsData variable, current page which can either be "events" for the right-col-content.html page or
             "project" from the project.html page, and passes the appendMeetingTimes function from projects.js that appends the sorted vrmsData
             returned by sortByDate to project.html. AppendMeetingTimes is only called if vrmsDataFetch is being called from project.js for the project.html page

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test PR to show CI running#1168

Test PR to show CI running#1168
ryanfkeller wants to merge 68 commits intogh-pagesfrom
frontend-unit-tests

ryanfkeller commented Nov 6, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 6, 2025

Uh oh!

github-actions bot commented Nov 6, 2025

Uh oh!

Check failure

Check failure

Check notice

Copilot Autofix

Check notice

Copilot Autofix

Check notice

Copilot Autofix

Check notice

Copilot Autofix

github-actions bot commented Nov 6, 2025

Uh oh!

github-actions bot commented Nov 6, 2025

Uh oh!

github-actions bot commented Nov 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

ryanfkeller commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes did you make?

Why did you make the changes (we will use this info to test)?

CodeQL Alerts

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Uh oh!

github-actions bot commented Nov 6, 2025

Uh oh!

github-actions bot commented Nov 6, 2025

Uh oh!

Check failure

Check failure

Check notice

Copilot Autofix

Check notice

Copilot Autofix

Check notice

Copilot Autofix

Check notice

Copilot Autofix

github-actions bot commented Nov 6, 2025

Uh oh!

github-actions bot commented Nov 6, 2025

Uh oh!

github-actions bot commented Nov 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ryanfkeller commented Nov 6, 2025 •

edited

Loading